linux-kernel - RE: [PATCH] tpm: Ensure that tpm chip has ops to check if it's defective

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR12MB6101238A319D88DEF067FC3EE225A@MN0PR12MB6101.namprd12.prod.outlook.com>
Date:   Thu, 29 Jun 2023 21:58:57 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "peterhuewe@....de" <peterhuewe@....de>,
        "jarkko@...nel.org" <jarkko@...nel.org>,
        "jgg@...pe.ca" <jgg@...pe.ca>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        "Aneesh Kumar K . V" <aneesh.kumar@...ux.ibm.com>,
        Sachin Sant <sachinp@...ux.ibm.com>
Subject: RE: [PATCH] tpm: Ensure that tpm chip has ops to check if it's
 defective



> -----Original Message-----
> From: Limonciello, Mario
> Sent: Friday, June 23, 2023 8:42 AM
> To: Greg KH <gregkh@...uxfoundation.org>
> Cc: peterhuewe@....de; jarkko@...nel.org; jgg@...pe.ca; linux-
> integrity@...r.kernel.org; linux-kernel@...r.kernel.org; Linux regressions
> mailing list <regressions@...ts.linux.dev>; Aneesh Kumar K . V
> <aneesh.kumar@...ux.ibm.com>; Sachin Sant <sachinp@...ux.ibm.com>
> Subject: Re: [PATCH] tpm: Ensure that tpm chip has ops to check if it's
> defective
> 
> 
> On 6/23/2023 1:08 AM, Greg KH wrote:
> > On Thu, Jun 22, 2023 at 10:04:27PM -0500, Mario Limonciello wrote:
> >> The ibmvtpm doesn't have `chip->ops` set, and so trying to check
> >> if it's a defective AMD fTPM doesn't work.
> >>
> >> Add an extra check to tpm_amd_is_rng_defective() to ensure the
> >> TPM being checked has `chip->ops`.
> >>
> >> Cc: Linux regressions mailing list <regressions@...ts.linux.dev>
> >> Reported-by: Aneesh Kumar K. V <aneesh.kumar@...ux.ibm.com>
> >> Reported-by: Sachin Sant <sachinp@...ux.ibm.com>
> >> Link: https://lore.kernel.org/lkml/99B81401-DB46-49B9-B321-
> CF832B50CAC3@...ux.ibm.com/
> >> Tested-by: Sachin Sant <sachinp@...ux.ibm.com>
> >> Fixes: bd8621ca1510 ("tpm: Add !tpm_amd_is_rng_defective() to the
> hwrng_unregister() call site")
> >> Fixes: f1324bbc4011 ("tpm: disable hwrng for fTPM on some AMD
> designs")
> >> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> >> ---
> >>   drivers/char/tpm/tpm-chip.c | 3 +++
> >>   1 file changed, 3 insertions(+)
> > No cc: stable on that list above?
> 
> Good point, my mistake on that miss.
> 
> If Jarkko agrees with the direction of this patch, I think
> it can be added while committing.
> 
> Thanks!

Since then, a much better patch was suggested.
Please discard this one.
https://lkml.org/lkml/2023/6/29/898