linux-kernel - Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7bf3aaa-581d-0625-5f18-6b9b062ea48d@linux.intel.com>
Date:   Thu, 29 Jun 2023 10:18:50 +0200
From:   Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Cezary Rojewski <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>
Subject: Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h

On 6/28/2023 4:44 PM, Andy Shevchenko wrote:
> On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote:
>> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers.
>> Almost every use contains additional comments to identify to which
>> platform those IDs refer to. Add those IDs to pci_ids.h header, so that
>> there is one place which defines those names.
> 
> ...
> 
>>   #define PCI_DEVICE_ID_INTEL_5400_FBD0	0x4035
>>   #define PCI_DEVICE_ID_INTEL_5400_FBD1	0x4036
>> +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N	0x4dc8
>> +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H	0x43c8
>> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0	0x4b55
>> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3	0x4b58
> 
> Can it be kept sorted by a value?
> 
> Didn't check the full list, though.
> 

My mistake, I've tried to add them in order, but must have missed this 
one, will review whole list again.