[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZJ1O1glAVAhFysPk@smile.fi.intel.com>
Date: Thu, 29 Jun 2023 12:28:54 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Amadeusz Sławiński
<amadeuszx.slawinski@...ux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
alsa-devel@...a-project.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org,
Cezary Rojewski <cezary.rojewski@...el.com>,
Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>
Subject: Re: [RFC PATCH 7/8] ASoC: Intel: Skylake: Update PCI ID list
On Thu, Jun 29, 2023 at 10:19:06AM +0200, Amadeusz Sławiński wrote:
> On 6/28/2023 4:52 PM, Andy Shevchenko wrote:
> > On Wed, Jun 28, 2023 at 10:51:34PM +0200, Amadeusz Sławiński wrote:
...
> > > + { PCI_DEVICE_DATA(INTEL, HDA_SKL_LP, &snd_soc_acpi_intel_skl_machines) },
> >
> > Do you really need TAB(s) in the parameter list?
>
> I did this to align entries, I know it is not that visible in this patch,
> but they are defined close to each other and I feel that it looks better if
> they are aligned, but can drop alignment if you prefer. Should I also drop
> them in other patches, as I don't see comment for that?
I think we may survive without TABs, but the maintainers may have the last
word on this.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists