[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aa45c265-5b90-b8a5-722e-4bcbc662660b@alliedtelesis.co.nz>
Date: Fri, 30 Jun 2023 04:06:58 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
"richard@....at" <richard@....at>,
"vigneshr@...com" <vigneshr@...com>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
"pierre.gondois@....com" <pierre.gondois@....com>,
"arnd@...db.de" <arnd@...db.de>,
"f.fainelli@...il.com" <f.fainelli@...il.com>
CC: "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: marvell: Add NAND flash controller to
AC5
On 26/06/23 15:12, Chris Packham wrote:
> The AC5/AC5X SoC has a NAND flash controller (NFC). Add this to
> the base SoC dtsi file as a disabled node. The NFC integration
> on the AC5/AC5X only supports SDR timing modes up to 3 so requires a
> dedicated compatible property so this limitation can be enforced.
>
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---
>
> Notes:
> Changes in v2:
> - New.
>
> arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> index 8bce64069138..74d644e0c29e 100644
> --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> @@ -296,6 +296,16 @@ spi1: spi@...a8000 {
> status = "disabled";
> };
>
> + nand: nand-controller@...b0000 {
> + compatible = "marvell,ac5-nand-controller";
> + reg = <0x0 0x805b0000 0x0 0x00000054>;
> + #address-cells = <0x1>;
> + #size-cells = <0x0>;
> + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cnm_clock>;
Actually I think I've just noticed a problem with this. The NFC uses a
different clock not the cnm one. It's not a gating clock like other SoCs
and they're close enough frequency wise so it mostly works. I'll update
this to add a dedicated nand-clock for v3.
> + status = "disabled";
> + };
> +
> gic: interrupt-controller@...00000 {
> compatible = "arm,gic-v3";
> #interrupt-cells = <3>;
Powered by blists - more mailing lists