linux-kernel - RE: [PATCH] EDAC/i10nm: shift exponent is negative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SA1PR11MB71305B71CCCC3D9305835202892AA@SA1PR11MB7130.namprd11.prod.outlook.com>
Date:   Fri, 30 Jun 2023 08:31:14 +0000
From:   "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To:     "Luck, Tony" <tony.luck@...el.com>, Koba Ko <koba.ko@...onical.com>
CC:     Borislav Petkov <bp@...en8.de>, James Morse <james.morse@....com>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] EDAC/i10nm: shift exponent is negative

> From: Luck, Tony <tony.luck@...el.com>
> Sent: Friday, June 30, 2023 12:12 AM
> To: Zhuo, Qiuxu <qiuxu.zhuo@...el.com>; Koba Ko <koba.ko@...onical.com>
> Cc: Borislav Petkov <bp@...en8.de>; James Morse <james.morse@....com>;
> Mauro Carvalho Chehab <mchehab@...nel.org>; Robert Richter
> <rric@...nel.org>; linux-edac@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH] EDAC/i10nm: shift exponent is negative
> 
> > I don't agree with simply skipping over a DIMM even EDAC doesn't expect
> to see it.
> > As the EDAC driver can still report errors for this DIMM once there are
> errors that occur in this DIMM.
> >
> > As per Tony's suggestion, could you test your kernel with
> CONFIG_EDAC_DEBUG=y and see the result?
> >
> > @Luck, Tony, Perhaps we may turn the debug print
> >
> >        edac_dbg(2, "bad %s = %d (raw=0x%x)\n", name, val, reg);
> >
> > to an error-print explicitly
> >
> >      skx_printk(KERN_ERR, "bad %s = %d (raw=0x%x)\n", name, val, reg);
> >
> > Let the user have the chance to notice there is a DIMM that EDAC doesn't
> expect to see.
> 
> We need both. Changing that debug message to a real error message will let
> the user know that EDAC doesn't recognize this DIMM (and will provide the
> information for you or me to fix the driver).
> 
> But we also need Ko's fix - because it makes no sense to just use that
> negative shift and pretend that EDAC knows how to handle this DIMM.
> 

OK.
@Koba Ko, could you make a new patch with Tony's suggestion? Thanks!

-Qiuxu