linux-kernel - Re: [PATCH 0/3] Configure usb0 as peripheral on am335x boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4fa80fd-1a6a-4718-0287-f5288cd9d912@baylibre.com>
Date:   Fri, 30 Jun 2023 10:30:48 +0200
From:   Julien Panis <jpanis@...libre.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-omap@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        vigneshr@...com, nm@...com
Subject: Re: [PATCH 0/3] Configure usb0 as peripheral on am335x boards

Hello Tony,

On 6/30/23 09:20, Tony Lindgren wrote:
> Hi,
>
> * Julien Panis <jpanis@...libre.com> [230629 13:10]:
>> This series configures usb0 dr_mode as 'peripheral' for am335x-evm,
>> am335x-evmsk, and am335x-icev2. This USB port is mainly used for
>> RNDIS and DFU.
> Is this a mini-B connector? Just wondering if it was originally attempted
> to be configured as OTG or how it ended up with a host configuration..

It's a micro USB-AB connector.
I don't know how it ended up with a host configuration, it looks like an oversight.
Maybe Vignesh or Nishanth can confirm (?)

>
>> Initially, a series was submitted to overlay dr_mode in u-boot specific
>> device trees ('<board>-u-boot.dtsi'):
>> https://lore.kernel.org/all/20230621-fix_usb_ether_init-v2-0-ff121f0e8d7a@baylibre.com/
>>
>> It was finally decided to modify linux device trees.
> Do we need these as fixes? If so is there a fixes tag for these?

I don't think so.
The u-boot series mentioned above was submitted to fix an error returned
by usb_ether_init() function. This error appeared after changes in u-boot
(arch/arm/mach-omap2/am33xx/board.c). The u-boot commit is:
6815a66ad7430 ("am33xx: musb: Remove unused configuration logic").
But this commit is right actually, and the error appeared because dr_mode
was not properly configured for am335x-evmsk and am335x-icev2 dts.
In other words, this u-boot commit is correct but revealed an oversight
in dr_mode configuration for these boards.
So, there is not a fixes tag here. That was just an omission in device trees.

>
> Regards,
>
> Tony

Julien