linux-kernel - Re: [PATCH v2 11/15] selftests/nolibc: prepare /tmp for tmpfs or ramfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230630101805.192734-1-falcon@tinylab.org>
Date:   Fri, 30 Jun 2023 18:18:05 +0800
From:   Zhangjin Wu <falcon@...ylab.org>
To:     thomas@...ch.de
Cc:     arnd@...db.de, falcon@...ylab.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org, w@....eu
Subject: Re: [PATCH v2 11/15] selftests/nolibc: prepare /tmp for tmpfs or ramfs

Hi, Thomas

> On 2023-06-30 07:52:03+0800, Zhangjin Wu wrote:
> > Let's create a /tmp directory and mount tmpfs there, if tmpfs is not
> > mountable, use ramfs as tmpfs.
> > 
> > tmpfs will be used instead of procfs for some tests.
> > 
> > Signed-off-by: Zhangjin Wu <falcon@...ylab.org>
> > ---
> >  tools/testing/selftests/nolibc/nolibc-test.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/selftests/nolibc/nolibc-test.c
> > index c0f5302ada5d..8e3e2792f5e3 100644
> > --- a/tools/testing/selftests/nolibc/nolibc-test.c
> > +++ b/tools/testing/selftests/nolibc/nolibc-test.c
> > @@ -1054,6 +1054,10 @@ int prepare(void)
> >  		}
> >  	}
> >  
> > +	/* try to mount /tmp if not mounted, if not mountable, use ramfs as tmpfs */
> > +	if (stat("/tmp/.", &stat_buf) == 0 || mkdir("/tmp", 0755) == 0)
> > +		mount("none", "/tmp", "tmpfs", 0, 0);
> > +
> 
> mkdir()
> mount()
> 
> without any error checking should do the same and be easier to read.
>

Yeah, will apply it, it saves a call for us.

Perhaps the other codes in prepare() can be cleaned up with the same method in the future too.

Thanks,
Zhangjin

> >  	return 0;
> >  }
> >  
> > -- 
> > 2.25.1
> >