linux-kernel - Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWRoNXrkD8ty4pUpFA-qQCMVF3wzXTCHFW4jYSy+dXivg@mail.gmail.com>
Date:   Fri, 30 Jun 2023 13:34:44 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Diederik de Haas <didi.debian@...ow.org>,
        Vincent Legoll <vincent.legoll@...il.com>
Subject: Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

Hi Sebastian,

On Thu, May 4, 2023 at 7:38 PM Sebastian Reichel
<sebastian.reichel@...labora.com> wrote:
> Split rk808 into a core and an i2c part in preparation for
> SPI support.
>
> Acked-for-MFD-by: Lee Jones <lee@...nel.org>
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com> # for RTC
> Tested-by: Diederik de Haas <didi.debian@...ow.org> # Rock64, Quartz64 Model A + B
> Tested-by: Vincent Legoll <vincent.legoll@...il.com> # Pine64 QuartzPro64
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Thanks for your patch, which is now commit c20e8c5b1203af37 ("mfd:
rk808: Split into core and i2c") in linus/master stable/master

> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1183,12 +1183,17 @@ config MFD_RC5T583
>           Additional drivers must be enabled in order to use the
>           different functionality of the device.
>
> -config MFD_RK808
> +config MFD_RK8XX
> +       bool

Is there any specific reason why this cannot be modular, like most (all?)
of its users that select it?

> +       select MFD_CORE
> +
> +config MFD_RK8XX_I2C
>         tristate "Rockchip RK805/RK808/RK809/RK817/RK818 Power Management Chip"
>         depends on I2C && OF
>         select MFD_CORE
>         select REGMAP_I2C
>         select REGMAP_IRQ
> +       select MFD_RK8XX
>         help
>           If you say yes here you get support for the RK805, RK808, RK809,
>           RK817 and RK818 Power Management chips.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds