linux-kernel - Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230630184833.o3lgqrtqzzwgb7nk@mercury.elektranox.org>
Date:   Fri, 30 Jun 2023 20:48:33 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lee Jones <lee@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Diederik de Haas <didi.debian@...ow.org>,
        Vincent Legoll <vincent.legoll@...il.com>
Subject: Re: [PATCH v8 05/14] mfd: rk808: split into core and i2c

Hi Geert,

On Fri, Jun 30, 2023 at 01:34:44PM +0200, Geert Uytterhoeven wrote:
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -1183,12 +1183,17 @@ config MFD_RC5T583
> >           Additional drivers must be enabled in order to use the
> >           different functionality of the device.
> >
> > -config MFD_RK808
> > +config MFD_RK8XX
> > +       bool
> 
> Is there any specific reason why this cannot be modular, like most (all?)
> of its users that select it?

I don't remember why I made that bool. Tristate should be perfectly
fine. Do you want to send a patch (I will test it of course), or should
I take care of it?

Greetings and thanks for the report,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)