linux-kernel - Re: [PATCH 0/5] ASoC: codecs: wcd938x/wcd934x: loglevel fix and cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07881d30-cec6-5885-ecb6-fbfaea88f3c1@linaro.org>
Date:   Fri, 30 Jun 2023 16:02:32 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Johan Hovold <johan+linaro@...nel.org>,
        Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] ASoC: codecs: wcd938x/wcd934x: loglevel fix and
 cleanups



On 30/06/2023 15:27, Johan Hovold wrote:
> When investigating a race in the wcd938x driver I noticed that the MBHC
> impedance measurements where printed at error loglevel which is clearly
> wrong.
> 
> Fix that, and clean up the logging somewhat by using dev_printk() and
> addressing some style issues.
> 
> Included are also two patches that drop the bogus inline keywords from
> the functions involved.
> 
> Johan
> 
> 
> Johan Hovold (5):
>    ASoC: codecs: wcd938x: fix mbhc impedance loglevel
>    ASoC: codecs: wcd938x: drop inline keywords
>    ASoC: codecs: wcd938x: use dev_printk() for impedance logging
>    ASoC: codecs: wcd934x: demote impedance printk loglevel
>    ASoC: codecs: wcd934x: drop inline keywords
> 

lgtm,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>

--srini


>   sound/soc/codecs/wcd934x.c |  8 ++++----
>   sound/soc/codecs/wcd938x.c | 17 +++++++++--------
>   2 files changed, 13 insertions(+), 12 deletions(-)
>