lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAHKB1w+DgbZYNL83XFUCPuPvvP6YdgjAZqPc_uG_eHAj71a=6Q@mail.gmail.com>
Date:   Fri, 30 Jun 2023 17:04:23 +0200
From:   Matteo Rizzo <matteorizzo@...gle.com>
To:     Gabriel Krisman Bertazi <krisman@...e.de>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        io-uring@...r.kernel.org, jordyzomer@...gle.com, evn@...gle.com,
        poprdi@...gle.com, corbet@....net, axboe@...nel.dk,
        asml.silence@...il.com, akpm@...ux-foundation.org,
        keescook@...omium.org, rostedt@...dmis.org,
        dave.hansen@...ux.intel.com, ribalda@...omium.org,
        chenhuacai@...nel.org, steve@....org, gpiccoli@...lia.com,
        ldufour@...ux.ibm.com, bhe@...hat.com, oleksandr@...alenko.name,
        Bart Van Assche <bvanassche@....org>, jmoyer@...hat.com,
        Jann Horn <jannh@...gle.com>
Subject: Re: [PATCH v2 1/1] Add a new sysctl to disable io_uring system-wide

On Thu, 29 Jun 2023 at 20:36, Gabriel Krisman Bertazi <krisman@...e.de> wrote:
>
> Thanks for adding the extra level for root-only rings.
>
> The patch looks good to me.
>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@...e.de>

Thanks everyone for the reviews! Unfortunately I forgot the subsystem name
in the commit message. Jann also pointed out to me internally that the
check in io_uring_allowed could race with another process that is trying to
change the sysctl. I will send a v3 that fixes both issues.

Thanks,
--
Matteo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ