linux-kernel - [PATCH] RDMA/bnxt_re: fix verbs undefined build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230701003059.23064-1-rdunlap@infradead.org>
Date:   Fri, 30 Jun 2023 17:30:59 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Jason Gunthorpe <jgg@...dia.com>,
        Leon Romanovsky <leonro@...dia.com>,
        linux-rdma@...r.kernel.org,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        Doug Ledford <dledford@...hat.com>
Subject: [PATCH] RDMA/bnxt_re: fix verbs undefined build errors

When INFINIBAND_USER_ACCESS is not set, the bnxt_re driver has
build errors:

ERROR: modpost: "uverbs_idr_class" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
ERROR: modpost: "ib_uverbs_get_ucontext_file" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
ERROR: modpost: "uverbs_destroy_def_handler" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!

Handle this case by making the driver depend on INFINIBAND_USER_ACCESS.

Fixes: 592e8b3226a2 ("RDMA/bnxt_re: Add bnxt_re driver build support")
Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Selvin Xavier <selvin.xavier@...adcom.com>
Cc: Jason Gunthorpe <jgg@...dia.com>
Cc: Leon Romanovsky <leonro@...dia.com>
Cc: linux-rdma@...r.kernel.org
Cc: Devesh Sharma <devesh.sharma@...adcom.com>
Cc: Somnath Kotur <somnath.kotur@...adcom.com>
Cc: Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
Cc: Doug Ledford <dledford@...hat.com>
---
 drivers/infiniband/hw/bnxt_re/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff -- a/drivers/infiniband/hw/bnxt_re/Kconfig b/drivers/infiniband/hw/bnxt_re/Kconfig
--- a/drivers/infiniband/hw/bnxt_re/Kconfig
+++ b/drivers/infiniband/hw/bnxt_re/Kconfig
@@ -3,6 +3,7 @@ config INFINIBAND_BNXT_RE
 	tristate "Broadcom Netxtreme HCA support"
 	depends on 64BIT
 	depends on INET && DCB && BNXT
+	depends on INFINIBAND_USER_ACCESS
 	help
 	  This driver supports Broadcom NetXtreme-E 10/25/40/50 gigabit
 	  RoCE HCAs.  To compile this driver as a module, choose M here: