linux-kernel - Re: [PATCH] RDMA/bnxt_re: fix verbs undefined build errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230703132814.GA32152@unreal>
Date:   Mon, 3 Jul 2023 16:28:14 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Jason Gunthorpe <jgg@...dia.com>, linux-rdma@...r.kernel.org,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Somnath Kotur <somnath.kotur@...adcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>,
        Doug Ledford <dledford@...hat.com>
Subject: Re: [PATCH] RDMA/bnxt_re: fix verbs undefined build errors

On Fri, Jun 30, 2023 at 05:30:59PM -0700, Randy Dunlap wrote:
> When INFINIBAND_USER_ACCESS is not set, the bnxt_re driver has
> build errors:
> 
> ERROR: modpost: "uverbs_idr_class" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> ERROR: modpost: "ib_uverbs_get_ucontext_file" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> ERROR: modpost: "uverbs_destroy_def_handler" [drivers/infiniband/hw/bnxt_re/bnxt_re.ko] undefined!
> 
> Handle this case by making the driver depend on INFINIBAND_USER_ACCESS.
> 
> Fixes: 592e8b3226a2 ("RDMA/bnxt_re: Add bnxt_re driver build support")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Selvin Xavier <selvin.xavier@...adcom.com>
> Cc: Jason Gunthorpe <jgg@...dia.com>
> Cc: Leon Romanovsky <leonro@...dia.com>
> Cc: linux-rdma@...r.kernel.org
> Cc: Devesh Sharma <devesh.sharma@...adcom.com>
> Cc: Somnath Kotur <somnath.kotur@...adcom.com>
> Cc: Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>
> Cc: Doug Ledford <dledford@...hat.com>
> ---
>  drivers/infiniband/hw/bnxt_re/Kconfig |    1 +
>  1 file changed, 1 insertion(+)

I liked this variant [1] more as bnxt_re driver can theoretically work
without INFINIBAND_USER_ACCESS too.

[1] https://lore.kernel.org/all/20230703113025.356682-1-arnd@kernel.org

Thanks