linux-kernel - Re: [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhJPsVWQLD_OeL9E0i0e6hdt5i_TPMkvh5u_+u4e9xUbHxFcQ@mail.gmail.com>
Date:   Mon, 3 Jul 2023 15:24:01 +0800
From:   Keguang Zhang <keguang.zhang@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     daniel.lezcano@...aro.org, tglx@...utronix.de,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clocksource/drivers/loongson1: set variable
 ls1x_timer_lock storage-class-specifier to static

> smatch reports
> drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
>   'ls1x_timer_lock' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@...hat.com>

Acked-by: Keguang Zhang <keguang.zhang@...il.com>

> ---
>  drivers/clocksource/timer-loongson1-pwm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
> index 6335fee03017..244d66835508 100644
> --- a/drivers/clocksource/timer-loongson1-pwm.c
> +++ b/drivers/clocksource/timer-loongson1-pwm.c
> @@ -28,7 +28,7 @@
>
>  #define CNTR_WIDTH             24
>
> -DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
> +static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
>
>  struct ls1x_clocksource {
>         void __iomem *reg_base;
> --
> 2.27.0
>


--
Best regards,

Keguang Zhang