linux-kernel - [tip: timers/core] clocksource/drivers/loongson1: Set variable ls1x_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <169344549074.27769.13641802860646483687.tip-bot2@tip-bot2>
Date:   Thu, 31 Aug 2023 01:31:30 -0000
From:   "tip-bot2 for Tom Rix" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Tom Rix <trix@...hat.com>, Keguang Zhang <keguang.zhang@...il.com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: timers/core] clocksource/drivers/loongson1: Set variable
 ls1x_timer_lock storage-class-specifier to static

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     bd0f3aac47e8f618ceae0120d7b989378a7c45f0
Gitweb:        https://git.kernel.org/tip/bd0f3aac47e8f618ceae0120d7b989378a7c45f0
Author:        Tom Rix <trix@...hat.com>
AuthorDate:    Sun, 02 Jul 2023 09:31:13 -04:00
Committer:     Daniel Lezcano <daniel.lezcano@...aro.org>
CommitterDate: Fri, 18 Aug 2023 12:13:03 +02:00

clocksource/drivers/loongson1: Set variable ls1x_timer_lock storage-class-specifier to static

smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
  'ls1x_timer_lock' was not declared. Should it be static?

This variable is only used in its defining file, so it should be static.

Signed-off-by: Tom Rix <trix@...hat.com>
Acked-by: Keguang Zhang <keguang.zhang@...il.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
Link: https://lore.kernel.org/r/20230702133113.3438049-1-trix@redhat.com
---
 drivers/clocksource/timer-loongson1-pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
index 6335fee..244d668 100644
--- a/drivers/clocksource/timer-loongson1-pwm.c
+++ b/drivers/clocksource/timer-loongson1-pwm.c
@@ -28,7 +28,7 @@
 
 #define CNTR_WIDTH		24
 
-DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
+static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
 
 struct ls1x_clocksource {
 	void __iomem *reg_base;