linux-kernel - RE: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb6cc27d71144bef9b7827f541fbeb43@realtek.com>
Date:   Mon, 3 Jul 2023 08:18:33 +0000
From:   Ping-Ke Shih <pkshih@...ltek.com>
To:     David Laight <David.Laight@...LAB.COM>,
        You Kangren <youkangren@...o.com>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "open list:MAC80211" <linux-wireless@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
CC:     "opensource.kernel@...o.com" <opensource.kernel@...o.com>
Subject: RE: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()



> -----Original Message-----
> From: David Laight <David.Laight@...LAB.COM>
> Sent: Thursday, June 29, 2023 9:28 PM
> To: Ping-Ke Shih <pkshih@...ltek.com>; You Kangren <youkangren@...o.com>; Johannes Berg
> <johannes@...solutions.net>; David S. Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
> Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; open list:MAC80211
> <linux-wireless@...r.kernel.org>; open list:NETWORKING [GENERAL] <netdev@...r.kernel.org>; open list
> <linux-kernel@...r.kernel.org>
> Cc: opensource.kernel@...o.com
> Subject: RE: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()
> 
> From: Ping-Ke Shih
> > Sent: 28 June 2023 02:49
> >
> > > -----Original Message-----
> > > From: You Kangren <youkangren@...o.com>
> > > Sent: Monday, June 26, 2023 6:48 PM
> > > To: Johannes Berg <johannes@...solutions.net>; David S. Miller <davem@...emloft.net>; Eric Dumazet
> > > <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; open
> > > list:MAC80211 <linux-wireless@...r.kernel.org>; open list:NETWORKING [GENERAL]
> > <netdev@...r.kernel.org>;
> > > open list <linux-kernel@...r.kernel.org>
> > > Cc: opensource.kernel@...o.com; youkangren@...o.com
> > > Subject: [PATCH] wifi：mac80211: Replace the ternary conditional operator with max()
> >
> > The semicolon of "wifi：" is different from others.
> >
> > >
> > > Replace the ternary conditional operator with max() to make the code clean
> > >
> > > Signed-off-by: You Kangren <youkangren@...o.com>
> > > ---
> > >  net/mac80211/tdls.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/net/mac80211/tdls.c b/net/mac80211/tdls.c
> > > index a4af3b7675ef..9f8b0842a616 100644
> > > --- a/net/mac80211/tdls.c
> > > +++ b/net/mac80211/tdls.c
> > > @@ -946,7 +946,7 @@ ieee80211_tdls_build_mgmt_packet_data(struct ieee80211_sub_if_data *sdata,
> > >         int ret;
> > >         struct ieee80211_link_data *link;
> > >
> > > -       link_id = link_id >= 0 ? link_id : 0;
> > > +       link_id = max(link_id, 0);
> >
> > Original logic means "if link_id < 0, then use default link (0)" instead of
> > "always use link_id larger than or equal to 0". So, I think max(link_id, 0) could
> > cause misunderstanding.
> 
> The clearest is probably:
>         if (link_id < 0)
>                 link_id = 0;
> 
> The compiler could easily generate the same code (compare and conditional
> move).
> 

They would be the same, but personally I prefer original single one line statement
that is clear to me.