linux-kernel - Re: [PATCH] arm64: dts: tegra: drop serial clock-names and reset-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64382cbe-d445-e229-d61c-38b2be94f417@nvidia.com>
Date:   Mon, 3 Jul 2023 10:58:02 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Thierry Reding <thierry.reding@...il.com>,
        devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: tegra: drop serial clock-names and
 reset-names


On 01/07/2023 09:14, Krzysztof Kozlowski wrote:
> On 28/06/2023 11:58, Jon Hunter wrote:
>>
>> On 23/01/2023 15:15, Krzysztof Kozlowski wrote:
>>> The serial node does not use clock-names and reset-names:
>>>
>>>     tegra234-sim-vdk.dtb: serial@...0000: Unevaluated properties are not allowed ('clock-names', 'reset-names' were unexpected)
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> ---
>>>    arch/arm64/boot/dts/nvidia/tegra132.dtsi | 8 --------
>>>    arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 --
>>>    arch/arm64/boot/dts/nvidia/tegra194.dtsi | 4 ----
>>>    arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 --------
>>>    arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 --
>>>    5 files changed, 24 deletions(-)
>>
>> ...
>>
>>> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> index b54353f31df5..372be226a7f4 100644
>>> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
>>> @@ -676,9 +676,7 @@ uarta: serial@...0000 {
>>>    			reg = <0x0 0x03100000 0x0 0x10000>;
>>>    			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>>>    			clocks = <&bpmp TEGRA234_CLK_UARTA>;
>>> -			clock-names = "serial";
>>>    			resets = <&bpmp TEGRA234_RESET_UARTA>;
>>> -			reset-names = "serial";
>>>    			status = "disabled";
>>>    		};
>>>    
>>
>>
>> Thierry, do you have a patch to convert the Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt to yaml? I have noticed that the above change now cause the hsuart to fail on Tegra234 ...
> 
> my patch was touching only the UART (8250), not the HSUART. These are
> different compatible and different drivers. Why do you think HSUART is
> affected here?

Yes they are completely different and your patch is obviously correct. 
However, for the Jetson AGX Orin board we update the compatible string 
to use the HSUART driver (in 
arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts) and here 
we don't add the necessary reset name which we should.

I was just flagging this issue to Thierry. I will send a fix for this.

Jon

-- 
nvpublic