linux-kernel - Re: [PATCH bpf-next v4 6/7] bpf, net: Support SO_REUSEPORT sockets with bpf_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN+4W8iktigV4j3t11HiVoo1BLW4r0UsDv+adaE_OZp_bemkOQ@mail.gmail.com>
Date:   Mon, 3 Jul 2023 10:53:03 +0100
From:   Lorenz Bauer <lmb@...valent.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.com>
Cc:     andrii@...nel.org, ast@...nel.org, bpf@...r.kernel.org,
        daniel@...earbox.net, davem@...emloft.net, dsahern@...nel.org,
        edumazet@...gle.com, haoluo@...gle.com, hemanthmalla@...il.com,
        joe@...ium.io, joe@...d.net.nz, john.fastabend@...il.com,
        jolsa@...nel.org, kpsingh@...nel.org, kuba@...nel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        martin.lau@...ux.dev, mykolal@...com, netdev@...r.kernel.org,
        pabeni@...hat.com, sdf@...gle.com, shuah@...nel.org,
        song@...nel.org, willemdebruijn.kernel@...il.com, yhs@...com
Subject: Re: [PATCH bpf-next v4 6/7] bpf, net: Support SO_REUSEPORT sockets
 with bpf_sk_assign

On Wed, Jun 28, 2023 at 7:50 PM Kuniyuki Iwashima <kuniyu@...zon.com> wrote:

> > +     } else {
> > +             return sk;
> > +     }
> > +
> > +     reuse_sk = inet6_lookup_reuseport(net, sk, skb, doff,
> > +                                       saddr, sport, daddr, ntohs(dport),
> > +                                       ehashfn);
> > +     if (!reuse_sk || reuse_sk == sk)
>
> nit: compiler might have optimised though, given here is the fast path,
> we can save reuse_sk == sk check.

Ack.