[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230703113112.380663-1-arnd@kernel.org>
Date: Mon, 3 Jul 2023 13:30:48 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: Marcel Holtmann <marcel@...tmann.org>,
Johan Hedberg <johan.hedberg@...il.com>,
Chris Lu <chris.lu@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>,
Jing Cai <jing.cai@...iatek.com>,
Abhishek Pandit-Subedi <abhishekpandit@...omium.org>,
Manish Mandlik <mmandlik@...gle.com>
Cc: Arnd Bergmann <arnd@...db.de>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Brian Gix <brian.gix@...el.com>, Pauli Virtanen <pav@....fi>,
Iulia Tanasescu <iulia.tanasescu@....com>,
linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] Bluetooth: coredump: fix building with coredump disabled
From: Arnd Bergmann <arnd@...db.de>
The btmtk driver uses an IS_ENABLED() check to conditionally compile
the coredump support, but this fails to build because the hdev->dump
member is in an #ifdef:
drivers/bluetooth/btmtk.c: In function 'btmtk_process_coredump':
drivers/bluetooth/btmtk.c:386:30: error: 'struct hci_dev' has no member named 'dump'
386 | schedule_delayed_work(&hdev->dump.dump_timeout,
| ^~
The struct member doesn't really make a huge difference in the total size,
so just remove the #ifdef around it to avoid adding similar checks
around each user.
Fixes: 872f8c253cb9e ("Bluetooth: btusb: mediatek: add MediaTek devcoredump support")
Fixes: 9695ef876fd12 ("Bluetooth: Add support for hci devcoredump")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
include/net/bluetooth/hci_core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index c0ca3f869c923..491ab83ccafc9 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -593,9 +593,7 @@ struct hci_dev {
const char *fw_info;
struct dentry *debugfs;
-#ifdef CONFIG_DEV_COREDUMP
struct hci_devcoredump dump;
-#endif
struct device dev;
--
2.39.2
Powered by blists - more mailing lists