linux-kernel - [PATCH] ovl: mark ovl_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon,  3 Jul 2023 13:31:33 +0200
From:   Arnd Bergmann <arnd@...nel.org>
To:     Miklos Szeredi <miklos@...redi.hu>,
        Amir Goldstein <amir73il@...il.com>,
        Christian Brauner <brauner@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>, linux-unionfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] ovl: mark ovl_redirect_mode() as static again

From: Arnd Bergmann <arnd@...db.de>

This function was moved to another file and is no longer marked
static there, causing a W=1 warning:

fs/overlayfs/params.c:92:13: error: no previous prototype for 'ovl_redirect_mode' [-Werror=missing-prototypes]

This was probably lost by accident during the refactoring, as there is
still no caller in another file, so add back the annotation.

Fixes: 06bcaa2dafb7e ("ovl: move all parameter handling into params.{c,h}")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 fs/overlayfs/params.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/overlayfs/params.c b/fs/overlayfs/params.c
index b8c2f6056a9a8..a63160dbb0f95 100644
--- a/fs/overlayfs/params.c
+++ b/fs/overlayfs/params.c
@@ -89,7 +89,7 @@ const struct constant_table ovl_parameter_redirect_dir[] = {
 	{}
 };
 
-const char *ovl_redirect_mode(struct ovl_config *config)
+static const char *ovl_redirect_mode(struct ovl_config *config)
 {
 	return ovl_parameter_redirect_dir[config->redirect_mode].name;
 }
-- 
2.39.2