linux-kernel - Re: [PATCH -next] xfs: Remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230703035017.GM11441@frogsfrogsfrogs>
Date:   Sun, 2 Jul 2023 20:50:17 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] xfs: Remove unneeded semicolon

On Mon, Jul 03, 2023 at 09:21:31AM +0800, Yang Li wrote:
> ./fs/xfs/xfs_extfree_item.c:723:3-4: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5728
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  fs/xfs/xfs_extfree_item.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_extfree_item.c b/fs/xfs/xfs_extfree_item.c
> index cdd8ebb6e7cb..f1a5ecf099aa 100644
> --- a/fs/xfs/xfs_extfree_item.c
> +++ b/fs/xfs/xfs_extfree_item.c
> @@ -720,7 +720,7 @@ xfs_efi_item_recover(
>  				requeue_only = true;
>  				continue;
>  			}
> -		};
> +		}

Looks ok,
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

>  
>  		if (error == -EFSCORRUPTED)
>  			XFS_CORRUPTION_ERROR(__func__, XFS_ERRLEVEL_LOW, mp,
> -- 
> 2.20.1.7.g153144c
>