linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a9e7dd9-8cc7-eeb9-cc63-3ec5d63c3a15@linaro.org>
Date:   Mon, 3 Jul 2023 18:08:20 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Johan Hovold <johan@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='

On 03/07/2023 11:56, Konrad Dybcio wrote:
>>>> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>>> index 895cafc11480..c4209e2d4b4e 100644
>>>> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>>>> @@ -155,7 +155,7 @@ CPU7: cpu@3 {
>>>>  
>>>>  		idle-states {
>>>>  			CPU_SLEEP_0: cpu-sleep-0 {
>>>> -				compatible ="qcom,idle-state-spc", "arm,idle-state";
>>>> +				compatible = "qcom,idle-state-spc", "arm,idle-state";
>>> Will conflict with:
>>>
>>> https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@linaro.org/
>>>
>>> there are also a couple of entries with property =\n\t{n}[a-z]
>>>
>>> Otherwise lgtm
>>  
>> Konrad, please remember to trim irrelevant context from your replies
>> (e.g. so that we don't have to skim through thousands of lines to find
>> a single comment).
> My actual reply begins at line 77, which is considerably less than
> thousands and is concluded by my signoff, which signifies the end
> of the message.

Your reply did not start at first scroll page. I had to scroll. Since
you put your reply inside big chunks of quote, it's very easy to miss
it. So I keep scrolling, keep scrolling, and so on, so on. Till I reach
end of email and I still don't see your reply.

Now in this email it was easy to find, because it was more than one
line. But in other responses I waste some time to find yours. Johan's
comment is here perfectly valid. Reading your responses is more time
consuming than required.

Best regards,
Krzysztof