linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f859959-d0d7-8417-68c9-19105be1844d@linaro.org>
Date:   Mon, 3 Jul 2023 18:09:57 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: minor whitespace cleanup around '='

On 03/07/2023 11:30, Konrad Dybcio wrote:
> On 2.07.2023 20:50, Krzysztof Kozlowski wrote:
>> The DTS code coding style expects exactly one space before and after '='
>> sign.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq8074.dtsi         |   8 +-
>>  .../dts/qcom/msm8916-samsung-serranove.dts    |   6 +-
>>  arch/arm64/boot/dts/qcom/msm8939.dtsi         |  14 +-
>>  .../boot/dts/qcom/msm8953-xiaomi-daisy.dts    |   2 +-
>>  .../boot/dts/qcom/msm8953-xiaomi-vince.dts    |   2 +-
>>  arch/arm64/boot/dts/qcom/msm8996.dtsi         |   6 +-
>>  .../dts/qcom/msm8996pro-xiaomi-natrium.dts    |   2 +-
>>  arch/arm64/boot/dts/qcom/msm8998.dtsi         |  18 +-
>>  arch/arm64/boot/dts/qcom/qcm2290.dtsi         |   2 +-
>>  arch/arm64/boot/dts/qcom/qcs404.dtsi          |   8 +-
>>  arch/arm64/boot/dts/qcom/sa8540p.dtsi         |   2 +-
>>  .../sc7280-herobrine-audio-rt5682-3mic.dtsi   |   2 +-
>>  arch/arm64/boot/dts/qcom/sc7280.dtsi          |   2 +-
>>  arch/arm64/boot/dts/qcom/sc8180x.dtsi         |   2 +-
>>  arch/arm64/boot/dts/qcom/sdm630.dtsi          |  10 +-
>>  .../dts/qcom/sdm845-oneplus-enchilada.dts     |   2 +-
>>  arch/arm64/boot/dts/qcom/sdx75.dtsi           |   4 +-
>>  arch/arm64/boot/dts/qcom/sm6115.dtsi          |   2 +-
>>  arch/arm64/boot/dts/qcom/sm8250.dtsi          | 198 +++++++++---------
>>  arch/arm64/boot/dts/qcom/sm8350.dtsi          | 196 ++++++++---------
>>  arch/arm64/boot/dts/qcom/sm8450.dtsi          | 194 ++++++++---------
>>  arch/arm64/boot/dts/qcom/sm8550.dtsi          | 196 ++++++++---------
>>  22 files changed, 439 insertions(+), 439 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> index 68839acbd613..00ed71936b47 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> @@ -794,10 +794,10 @@ frame@...8000 {
>>  
>>  		pcie1: pci@...00000 {
>>  			compatible = "qcom,pcie-ipq8074";
>> -			reg =  <0x10000000 0xf1d>,
>> -			       <0x10000f20 0xa8>,
>> -			       <0x00088000 0x2000>,
>> -			       <0x10100000 0x1000>;
>> +			reg = <0x10000000 0xf1d>,
>> +			      <0x10000f20 0xa8>,
>> +			      <0x00088000 0x2000>,
>> +			      <0x10100000 0x1000>;
>>  			reg-names = "dbi", "elbi", "parf", "config";
>>  			device_type = "pci";
>>  			linux,pci-domain = <1>;
>> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
>> index 15dc246e84e2..126e8b5cf49f 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
>> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-serranove.dts
>> @@ -219,9 +219,9 @@ magnetometer@2e {
>>  		compatible = "yamaha,yas537";
>>  		reg = <0x2e>;
>>  
>> -		mount-matrix =  "0",  "1",  "0",
>> -				"1",  "0",  "0",
>> -				"0",  "0", "-1";
>> +		mount-matrix = "0",  "1",  "0",
>> +			       "1",  "0",  "0",
>> +			       "0",  "0", "-1";
>>  	};
>>  };
>>  
>> diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>> index 895cafc11480..c4209e2d4b4e 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
>> @@ -155,7 +155,7 @@ CPU7: cpu@3 {
>>  
>>  		idle-states {
>>  			CPU_SLEEP_0: cpu-sleep-0 {
>> -				compatible ="qcom,idle-state-spc", "arm,idle-state";
>> +				compatible = "qcom,idle-state-spc", "arm,idle-state";
> Will conflict with:
> 
> https://lore.kernel.org/linux-arm-msm/20230627-topic-more_bindings-v1-2-6b4b6cd081e5@linaro.org/
> 
> there are also a couple of entries with property =\n\t{n}[a-z]
> 
> Otherwise lgtm
> 
... and if I want to reply to this, I have to find and remove entire big
piece of unrelated quote. So you put this burden on me and you keep
insisting that everything is easy. No, it is not.

Anyway, the remaining =\t properties were done like this on purpose for
easier reading. What I am cleaning here are the cases where there are no
benefits of such style.

Best regards,
Krzysztof