linux-kernel - Re: [PATCH blktests v3 0/3] More fixes for FC enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op7hkwiauywfosn4q4h3cihdzcoy4m4vqthanv4urwxo4trazy@2qtljklkt4ry>
Date:   Tue, 4 Jul 2023 07:08:57 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Daniel Wagner <dwagner@...e.de>
CC:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Hannes Reinecke <hare@...e.de>,
        James Smart <jsmart2021@...il.com>
Subject: Re: [PATCH blktests v3 0/3] More fixes for FC enabling

On Jul 03, 2023 / 11:16, Daniel Wagner wrote:
> I've rebased the series on the current HEAD and moved the def_hostnqn bits from
> the second patch to the third. This should make it more consistent in commit
> history.
> 
> Also retested and found a bug in the context matching code in libnvme which I
> post a fix too.

Thanks Daniel.

One thing I noticed is that now the 3rd patch removes the references from
nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since
I see the motivation discussed here [1]. I will wait for several days to make
sure it's ok for others. In case anyone relies on those files to set up blktests
environment, please speak up.

[1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/

Other that, changes in v3 looks good to me. If there is no voice, I'll apply
the patches as they are.