[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9125301c-61e0-96e4-35be-94d9c9565e90@nvidia.com>
Date: Thu, 6 Jul 2023 06:51:30 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@....com>,
Daniel Wagner <dwagner@...e.de>,
Yi Zhang <yi.zhang@...hat.com>,
Max Gurtovoy <mgurtovoy@...dia.com>
CC: "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
Chaitanya Kulkarni <chaitanyak@...dia.com>,
Sagi Grimberg <sagi@...mberg.me>,
Hannes Reinecke <hare@...e.de>,
James Smart <jsmart2021@...il.com>
Subject: Re: [PATCH blktests v3 0/3] More fixes for FC enabling
On 7/4/2023 12:08 AM, Shinichiro Kawasaki wrote:
> On Jul 03, 2023 / 11:16, Daniel Wagner wrote:
>> I've rebased the series on the current HEAD and moved the def_hostnqn bits from
>> the second patch to the third. This should make it more consistent in commit
>> history.
>>
>> Also retested and found a bug in the context matching code in libnvme which I
>> post a fix too.
>
> Thanks Daniel.
>
> One thing I noticed is that now the 3rd patch removes the references from
> nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since
> I see the motivation discussed here [1]. I will wait for several days to make
> sure it's ok for others. In case anyone relies on those files to set up blktests
> environment, please speak up.
>
> [1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/
>
> Other that, changes in v3 looks good to me. If there is no voice, I'll apply
> the patches as they are.
Adding Max and Yi who were part of original discussion [1].
-ck
Powered by blists - more mailing lists