linux-kernel - Re: [PATCH blktests v3 0/3] More fixes for FC enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <gh6q6aq5sdh4elap2zisccrwrxtf5bnh6yerv44osc4tjy5qum@6vd2yvqhdf6a>
Date:   Mon, 10 Jul 2023 03:52:37 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Chaitanya Kulkarni <chaitanyak@...dia.com>
CC:     Daniel Wagner <dwagner@...e.de>, Yi Zhang <yi.zhang@...hat.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Sagi Grimberg <sagi@...mberg.me>,
        Hannes Reinecke <hare@...e.de>,
        James Smart <jsmart2021@...il.com>
Subject: Re: [PATCH blktests v3 0/3] More fixes for FC enabling

On Jul 06, 2023 / 06:51, Chaitanya Kulkarni wrote:
> 
> On 7/4/2023 12:08 AM, Shinichiro Kawasaki wrote:
> > On Jul 03, 2023 / 11:16, Daniel Wagner wrote:
> >> I've rebased the series on the current HEAD and moved the def_hostnqn bits from
> >> the second patch to the third. This should make it more consistent in commit
> >> history.
> >>
> >> Also retested and found a bug in the context matching code in libnvme which I
> >> post a fix too.
> > 
> > Thanks Daniel.
> > 
> > One thing I noticed is that now the 3rd patch removes the references from
> > nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since
> > I see the motivation discussed here [1]. I will wait for several days to make
> > sure it's ok for others. In case anyone relies on those files to set up blktests
> > environment, please speak up.
> > 
> > [1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/
> > 
> > Other that, changes in v3 looks good to me. If there is no voice, I'll apply
> > the patches as they are.
> 
> Adding Max and Yi who were part of original discussion [1].

I saw no response to this v3 series, so I've applied it. Of note is that I
resolved a simple conflict of the 3rd patch and added a note about /etc/nvme/*
in its commit message. Daniel, thanks for this work.

However, after this action, I noticed that Max made a question in the e-mail
thread of the v1 series. I might have been going too fast. I hope Daniel can
answer that question.