linux-kernel - Re: [PATCH] kernel: reboot: Remove unnecessary ‘0’ values from ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6d8593f4-3dcd-7db8-899b-2f96e02a09a0@infradead.org>
Date:   Sun, 9 Jul 2023 20:53:29 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Li zeming <zeming@...china.com>, rafael.j.wysocki@...el.com,
        kai.heng.feng@...onical.com, dmitry.osipenko@...labora.com
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: reboot: Remove unnecessary ‘0’ values from ret



On 7/11/23 13:21, Li zeming wrote:
> ret is assigned first, so it does not need to initialize the assignment.
> 
> Signed-off-by: Li zeming <zeming@...china.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.


> ---
>  kernel/reboot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> index 3bba88c7ffc6..e00a02a74694 100644
> --- a/kernel/reboot.c
> +++ b/kernel/reboot.c
> @@ -702,7 +702,7 @@ SYSCALL_DEFINE4(reboot, int, magic1, int, magic2, unsigned int, cmd,
>  {
>  	struct pid_namespace *pid_ns = task_active_pid_ns(current);
>  	char buffer[256];
> -	int ret = 0;
> +	int ret;
>  
>  	/* We only trust the superuser with rebooting the system. */
>  	if (!ns_capable(pid_ns->user_ns, CAP_SYS_BOOT))

-- 
~Randy