[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CALs4sv2=g8cf_dmDdD=AM97+SDxPD61_OEzM1nxmohPOACk9Kg@mail.gmail.com>
Date: Mon, 10 Jul 2023 09:32:15 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Yu Hao <yhao016@....edu>
Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ethernet: e1000e: Fix possible uninit bug
On Mon, Jul 10, 2023 at 6:27 AM Yu Hao <yhao016@....edu> wrote:
>
> The variable phy_data should be initialized in function e1e_rphy.
> However, there is not return value check, which means there is a
> possible uninit read later for the variable.
>
> Signed-off-by: Yu Hao <yhao016@....edu>
> ---
Shouldn't this be a v2? You are addressing a comment on your original
patch right?
Also please specify the target tree name. This may need a fixes tag also.
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
> index 771a3c909c45..a807358a8174 100644
> --- a/drivers/net/ethernet/intel/e1000e/netdev.c
> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
> @@ -6909,7 +6909,7 @@ static int __e1000_resume(struct pci_dev *pdev)
>
> /* report the system wakeup cause from S3/S4 */
> if (adapter->flags2 & FLAG2_HAS_PHY_WAKEUP) {
> - u16 phy_data;
> + u16 phy_data = 0;
>
> e1e_rphy(&adapter->hw, BM_WUS, &phy_data);
> if (phy_data) {
> --
> 2.34.1
>
>
Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)
Powered by blists - more mailing lists