linux-kernel - Re: [PATCH] PCI: dwc: Provide deinit callback for i.MX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e7d3961-4189-4141-a342-d15a34fefc9d@sirena.org.uk>
Date:   Tue, 4 Jul 2023 12:54:55 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Richard Zhu <hongxing.zhu@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Rob Herring <robh@...nel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: dwc: Provide deinit callback for i.MX

On Tue, Jul 04, 2023 at 08:50:15AM -0300, Fabio Estevam wrote:

> I recall seeing this regulator warning before:
> f81f095e8771 ("PCI: imx6: Allow to probe when dw_pcie_wait_for_link() fails")

> I think the real issue is why does the probe fail when the link is not up?

Well, they're both issues - if someone unloads or unbinds the driver we
can still trigger this, even if the probe succeeded.

> It should not fail to probe. At least, this was the original intention
> with Rob's commit:

> 886a9c134755 ("PCI: dwc: Move link handling into common code")

> +       return 0;
> 
>  err_remove_edma:
>         dw_pcie_edma_remove(pci);

I have no idea about doing this, all the PCI on the board that I care
about seems to work fine (and worked fine even with the failure, I'm not
sure this is being generated by a link that's in use).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)