linux-kernel - Re: [PATCH] mm: page_alloc: avoid false page outside zone error info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <feb41501-163a-58d6-1996-8d6ebc9d800e@huawei.com>
Date:   Tue, 4 Jul 2023 20:36:00 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: page_alloc: avoid false page outside zone error info

On 2023/7/4 20:13, Matthew Wilcox wrote:
> On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote:
>> @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page)
>>  		sp = zone->spanned_pages;
>>  		if (!zone_spans_pfn(zone, pfn))
>>  			ret = 1;
>> +		else
>> +			ret = 0;
> 
> Surely 'ret = zone_spans_pfn(zone, pfn);' ?

Do you mean 'ret = !zone_spans_pfn(zone, pfn);'?  This format looks fine to me.

> 
> Also, did you spot this by inspection or do you have a test-case or bug
> report?  Should this have a Fixes: tag?

This is from code inspection. The race window should be really small thus hard to trigger
in real world. And yes, it seems Fixes tag is a really ancient commit:

	Fixes: bdc8cb984576 ("[PATCH] memory hotplug locking: zone span seqlock")

Thanks for your comment and reply.