linux-kernel - Re: [PATCH] mm: page_alloc: avoid false page outside zone error info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKQM2lg7524dIAQl@casper.infradead.org>
Date:   Tue, 4 Jul 2023 13:13:14 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: page_alloc: avoid false page outside zone error info

On Tue, Jul 04, 2023 at 07:18:23PM +0800, Miaohe Lin wrote:
> @@ -470,6 +470,8 @@ static int page_outside_zone_boundaries(struct zone *zone, struct page *page)
>  		sp = zone->spanned_pages;
>  		if (!zone_spans_pfn(zone, pfn))
>  			ret = 1;
> +		else
> +			ret = 0;

Surely 'ret = zone_spans_pfn(zone, pfn);' ?

Also, did you spot this by inspection or do you have a test-case or bug
report?  Should this have a Fixes: tag?