linux-kernel - Re: [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZKXVJ1U8UbFSrsqM@lizhi-Precision-Tower-5810>
Date:   Wed, 5 Jul 2023 16:40:07 -0400
From:   Frank Li <Frank.li@....com>
To:     Suzuki K Poulose <suzuki.poulose@....com>
Cc:     imx@...ts.linux.dev, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        coresight@...ts.linaro.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components

On Tue, Jul 04, 2023 at 04:20:18PM +0100, Suzuki K Poulose wrote:
> On 05/05/2023 20:51, Frank Li wrote:
> > Add coresight trace components (ETM, ETF, ETB and Funnel).
> > 
> > ┌───────┐  ┌───────┐  ┌───────┐
> > │ CPU0  ├─►│ ETM0  ├─►│       │
> > └───────┘  └───────┘  │       │
> >                        │       │
> > ┌───────┐  ┌───────┐  │  ATP  │
> > │ CPU1  ├─►│ ETM1  ├─►│       │
> > └───────┘  └───────┘  │       │
> >                        │ FUNNEL│
> > ┌───────┐  ┌───────┐  │       │
> > │ CPU2  ├─►│ ETM2  ├─►│       │
> > └───────┘  └───────┘  │       │   ┌─────┐  ┌─────┐
> >                        │       │   │     │  │     │
> > ┌───────┐  ┌───────┐  │       │   │ M7  │  │ DSP │
> > │ CPU3  ├─►│ ETM3  ├─►│       │   │     │  │     │
> > └───────┘  └───────┘  └───┬───┘   └──┬──┘  └──┬──┘               AXI
> >                            │          │        │                   ▲
> >                            ▼          ▼        ▼                   │
> >                        ┌───────────────────────────┐   ┌─────┐   ┌─┴──┐
> >                        │          ATP FUNNEL       ├──►│ETF  ├─► │ETR │
> >                        └───────────────────────────┘   └─────┘   └────┘
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 179 ++++++++++++++++++++++
> >   1 file changed, 179 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index a19224fe1a6a..0fa74477b9e1 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -304,6 +304,185 @@ soc: soc@0 {
> >   		nvmem-cells = <&imx8mp_uid>;
> >   		nvmem-cell-names = "soc_unique_id";
> > +		etm0: etm@...40000 {
> > +			compatible = "arm,coresight-etm4x", "arm,primecell";
> > +			reg = <0x28440000 0x10000>;
> > +			arm,primecell-periphid = <0xbb95d>;
> 
> Why is this needed (and for all the ETMs) ?

Reg size is wrong set to 64k(should be 4k), so crash when call amba_read_periphid().
let me send out a fixed patch.
Thank you for found it.

Frank

> 
> Suzuki
>