linux-kernel - Re: [PATCH v2 3/3] ASoC: amd: vangogh: Add support for NAU8821/MAX98388 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a404cb2-ef2d-4df5-1f91-e5562f8204af@collabora.com>
Date:   Thu, 6 Jul 2023 00:31:53 +0300
From:   Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Syed Saba Kareem <Syed.SabaKareem@....com>,
        Vijendar Mukunda <Vijendar.Mukunda@....com>,
        Arnd Bergmann <arnd@...db.de>,
        Randy Dunlap <rdunlap@...radead.org>,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH v2 3/3] ASoC: amd: vangogh: Add support for
 NAU8821/MAX98388 variant

On 7/5/23 19:16, Mark Brown wrote:
> On Wed, Jul 05, 2023 at 04:43:41PM +0300, Cristian Ciocaltea wrote:
> 
>> +static int acp5x_max98388_hw_params(struct snd_pcm_substream *substream,
>> +				    struct snd_pcm_hw_params *params)
>> +{
>> +	struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
>> +	struct snd_soc_dai *dai = snd_soc_card_get_codec_dai(rtd->card,
>> +							     ACP5X_MAX98388_DAI_NAME);
>> +	int ret;
>> +
>> +	ret = snd_soc_dai_set_fmt(dai,
>> +				  SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_I2S |
>> +				  SND_SOC_DAIFMT_NB_NF);
>> +	if (ret < 0)
>> +		dev_err(dai->dev, "Failed to set format: %d\n", ret);
>> +
>> +	return ret;
>> +}
> 
> This never varies, why not just set it up statically in the dai_link?

Right, will handle this in v3.

Thanks,
Cristian