[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <808dac44-a72c-4675-1e4a-0ed96190efb4@linaro.org>
Date: Wed, 5 Jul 2023 08:21:31 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: William Qiu <william.qiu@...rfivetech.com>,
devicetree@...r.kernel.org, linux-spi@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Emil Renner Berthing <kernel@...il.dk>,
Ziv Xu <ziv.xu@...rfivetech.com>
Subject: Re: [PATCH v4 2/3] spi: cadence-quadspi: Add clock configuration for
StarFive JH7110 QSPI
On 04/07/2023 11:04, William Qiu wrote:
> Add QSPI clock operation in device probe.
>
> Signed-off-by: William Qiu <william.qiu@...rfivetech.com>
> Reviewed-by: Hal Feng <hal.feng@...rfivetech.com>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306022017.UbwjjWRN-lkp@intel.com/
> Reported-by: Julia Lawall <julia.lawall@...ia.fr>
> Closes: https://lore.kernel.org/r/202306040644.6ZHs55x4-lkp@intel.com/
>
> @@ -1840,6 +1858,8 @@ static int cqspi_resume(struct device *dev)
> struct spi_master *master = dev_get_drvdata(dev);
>
> clk_prepare_enable(cqspi->clk);
> + if (of_device_is_compatible(dev->of_node, "starfive,jh7110-qspi"))
Don't add compatible checks inside the code. It does not scale. We
expect compatibles to be listed only in one place - of_device_id - and
customize driver with match data / quirks / flags.
Comment applies to all your diff hunks.
> + clk_bulk_prepare_enable(cqspi->num_clks, cqspi->clks);
> cqspi_wait_idle(cqspi);
> cqspi_controller_init(cqspi);
>
Best regards,
Krzysztof
Powered by blists - more mailing lists