linux-kernel - Re: [PATCH v1] drivers: media: remove duplicate assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd9bcc6d-dc69-cd25-d621-d97a7ba2866d@xs4all.nl>
Date:   Wed, 5 Jul 2023 08:21:28 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Minjie Du <duminjie@...o.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        "open list:MEDIA INPUT INFRASTRUCTURE (V4L/DVB)" 
        <linux-media@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Cc:     opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers: media: remove duplicate assignments

On 05/07/2023 06:47, Minjie Du wrote:
> make second_timeout avoid double assignment.

Please post a v2 where you mention the driver name in the subject.

"drivers: media:" suggests a patch touching on many media drivers instead
of just a single driver.

Regards,

	Hans

> 
> Signed-off-by: Minjie Du <duminjie@...o.com>
> ---
>  drivers/media/pci/saa7164/saa7164-fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/pci/saa7164/saa7164-fw.c b/drivers/media/pci/saa7164/saa7164-fw.c
> index 363689484..cc9f384f7 100644
> --- a/drivers/media/pci/saa7164/saa7164-fw.c
> +++ b/drivers/media/pci/saa7164/saa7164-fw.c
> @@ -271,7 +271,6 @@ int saa7164_downloadfirmware(struct saa7164_dev *dev)
>  			dprintk(DBGLVL_FW, "%s() Loader 1 has loaded.\n",
>  				__func__);
>  			first_timeout = SAA_DEVICE_TIMEOUT;
> -			second_timeout = 60 * SAA_DEVICE_TIMEOUT;
>  			second_timeout = 100;
>  
>  			err_flags = saa7164_readl(SAA_SECONDSTAGEERROR_FLAGS);