linux-kernel - Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7536d9a3-4738-2bc2-e33e-d93347893865@kernel.org>
Date:   Wed, 5 Jul 2023 20:10:16 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Alistair Francis <alistair@...stair23.me>,
        marek.vasut+renesas@...il.com, yoshihiro.shimoda.uh@...esas.com,
        linux-pci@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     lpieralisi@...nel.org, kw@...ux.com, robh@...nel.org,
        bhelgaas@...gle.com, alistair23@...il.com
Subject: Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of
 linux/pci-epc.h

On 7/5/23 19:48, Alistair Francis wrote:
> pci-epc.h doesn't define the members of the pci_epf_header struct, so
> trying to access them results in errors like this:
> 
>     error: invalid use of undefined type 'struct pci_epf_header'
>       167 |                 val = hdr->vendorid;
> 
> Instead let's include pci-epf.h which not only defines the
> pci_epf_header but also includes pci-epc.h.
> 
> Signed-off-by: Alistair Francis <alistair@...stair23.me>

It is odd that the the build bot did not detect this...

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

> ---
>  drivers/pci/controller/pcie-rcar-ep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index f9682df1da61..5afc91d11eef 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -10,7 +10,7 @@
>  #include <linux/of_address.h>
>  #include <linux/of_platform.h>
>  #include <linux/pci.h>
> -#include <linux/pci-epc.h>
> +#include <linux/pci-epf.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  

-- 
Damien Le Moal
Western Digital Research