linux-kernel - Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 5 Jul 2023 20:44:43 +0900
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Damien Le Moal <dlemoal@...nel.org>
Cc:     Alistair Francis <alistair@...stair23.me>,
        marek.vasut+renesas@...il.com, yoshihiro.shimoda.uh@...esas.com,
        linux-pci@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, lpieralisi@...nel.org,
        robh@...nel.org, bhelgaas@...gle.com, alistair23@...il.com
Subject: Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of
 linux/pci-epc.h

Hello,

> > pci-epc.h doesn't define the members of the pci_epf_header struct, so
> > trying to access them results in errors like this:
> > 
> >     error: invalid use of undefined type 'struct pci_epf_header'
> >       167 |                 val = hdr->vendorid;
> > 
> > Instead let's include pci-epf.h which not only defines the
> > pci_epf_header but also includes pci-epc.h.

[...]
> It is odd that the the build bot did not detect this...

This is a bit of a surprise to me too, especially since none of the usual
bots pick this up, and I can't seem to find such a failure in the nightly
CI logs either.

Alistair, how did you stumble into this issue?  Also, which version or
a tree would that be?
  
  Thank you!

	Krzysztof