linux-kernel - Re: [PATCH 8/8] pata: imx: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jul 2023 08:40:22 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Yangtao Li <frank.li@...o.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>
Cc:     linux-ide@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] pata: imx: Use
 devm_platform_get_and_ioremap_resource()

On 7/6/23 21:42, Yangtao Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

Patch title:

ata: pata_imx: ...

> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>
> ---
>  drivers/ata/pata_imx.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
> index 4013f28679a9..65d09ec94c12 100644
> --- a/drivers/ata/pata_imx.c
> +++ b/drivers/ata/pata_imx.c
> @@ -164,8 +164,7 @@ static int pata_imx_probe(struct platform_device *pdev)
>  	ap->pio_mask = ATA_PIO4;
>  	ap->flags |= ATA_FLAG_SLAVE_POSS;
>  
> -	io_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	priv->host_regs = devm_ioremap_resource(&pdev->dev, io_res);
> +	priv->host_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &io_res);
>  	if (IS_ERR(priv->host_regs)) {
>  		ret = PTR_ERR(priv->host_regs);
>  		goto err;

-- 
Damien Le Moal
Western Digital Research