linux-kernel - Re: [PATCH v2 3/4] hugetlbfs: improve read HWPOISON hugepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jul 2023 09:28:41 +0900
From:   Naoya Horiguchi <naoya.horiguchi@...ux.dev>
To:     Jiaqi Yan <jiaqiyan@...gle.com>
Cc:     mike.kravetz@...cle.com, naoya.horiguchi@....com,
        songmuchun@...edance.com, shy828301@...il.com,
        linmiaohe@...wei.com, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        duenwen@...gle.com, axelrasmussen@...gle.com, jthoughton@...gle.com
Subject: Re: [PATCH v2 3/4] hugetlbfs: improve read HWPOISON hugepage

On Fri, Jun 23, 2023 at 04:40:14PM +0000, Jiaqi Yan wrote:
> When a hugepage contains HWPOISON pages, read() fails to read any byte
> of the hugepage and returns -EIO, although many bytes in the HWPOISON
> hugepage are readable.
> 
> Improve this by allowing hugetlbfs_read_iter returns as many bytes as
> possible. For a requested range [offset, offset + len) that contains
> HWPOISON page, return [offset, first HWPOISON page addr); the next read
> attempt will fail and return -EIO.
> 
> Signed-off-by: Jiaqi Yan <jiaqiyan@...gle.com>

Looks good to me.

Reviewed-by: Naoya Horiguchi <naoya.horiguchi@....com>