linux-kernel - 回复: 回复: [PATCH] block: mq-deadline: rename sort_list to sort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYZPR02MB559543EE78F4052B6995EBAEC62DA@TYZPR02MB5595.apcprd02.prod.outlook.com>
Date:   Fri, 7 Jul 2023 00:26:28 +0000
From:   李培锋(wink) <lipeifeng@...o.com>
To:     Jens Axboe <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        张诗明(Simon Zhang) 
        <zhangshiming@...o.com>, 郭健 <guojian@...o.com>,
        Bart Van Assche <bvanassche@....org>
Subject: 回复: 回复: [PATCH] block: mq-deadline: rename sort_list to sort_rb

>>>>> Mq-deadline would store request in list:fifo_list and 
>>>>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which 
>>>>> is beneficial for understanding.
>> 
>>>> Huh? I think this patch makes the code less readable instead of more readable ...
>> 
>>> Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort'
>>> So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable for rb_root ratherthan *_list for reader.
>> 
>> Hi Sir?
>> Should it be merged for the above reason? Hope for your reply, thanks.

>No, the patch makes no sense. I agree with Bart that it doesn't make it any more readable, in fact it's worse. We have a sort and fifo list, the backing data structure isn't that exciting by itself.

That is okay, thank you for your reply and respect both of you.

-----邮件原件-----
发件人: Jens Axboe <axboe@...nel.dk> 
发送时间: 2023年7月6日 22:05
收件人: 李培锋(wink) <lipeifeng@...o.com>
抄送: linux-block@...r.kernel.org; linux-kernel@...r.kernel.org; 张诗明(Simon Zhang) <zhangshiming@...o.com>; 郭健 <guojian@...o.com>; Bart Van Assche <bvanassche@....org>
主题: Re: 回复: [PATCH] block: mq-deadline: rename sort_list to sort_rb

On 7/6/23 3:27?AM, ???(wink) wrote:
>>>> Mq-deadline would store request in list:fifo_list and 
>>>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which 
>>>> is beneficial for understanding.
> 
>>> Huh? I think this patch makes the code less readable instead of more readable ...
> 
>> Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort'
>> So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable for rb_root ratherthan *_list for reader.
> 
> Hi Sir?
> Should it be merged for the above reason? Hope for your reply, thanks.

No, the patch makes no sense. I agree with Bart that it doesn't make it any more readable, in fact it's worse. We have a sort and fifo list, the backing data structure isn't that exciting by itself.

--
Jens Axboe