linux-kernel - [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7554aadc5afb915ee1065cea56053cb6@208suo.com>
Date:   Sun, 09 Jul 2023 20:35:06 +0800
From:   xuanzhenggang001@...suo.com
To:     ysato@...rs.sourceforge.jp, dalias@...c.org,
        glaubitz@...sik.fu-berlin.de
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of
 'unsigned'

Fix the following warnings reported by checkpatch:

arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare 
use of 'unsigned'
arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare 
use of 'unsigned'

Signed-off-by: Zhenggang Xuan <xuanzhenggang001@...suo.com>
---
  arch/sh/drivers/heartbeat.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c
index 24391b444b28..07f04ed0d517 100644
--- a/arch/sh/drivers/heartbeat.c
+++ b/arch/sh/drivers/heartbeat.c
@@ -30,7 +30,7 @@
  static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };

  static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
-                    unsigned bit, unsigned int inverted)
+                    unsigned int bit, unsigned int inverted)
  {
      unsigned int new;

@@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct 
heartbeat_data *hd,
  static void heartbeat_timer(struct timer_list *t)
  {
      struct heartbeat_data *hd = from_timer(hd, t, timer);
-    static unsigned bit = 0, up = 1;
+    static unsigned int bit = 0, up = 1;

      heartbeat_toggle_bit(hd, bit, hd->flags & HEARTBEAT_INVERTED);