[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMuHMdWLxc7Tu2FNMRiO_LMjM2VSdtmHAiMeWv-+NgxA9+fqeQ@mail.gmail.com>
Date: Wed, 18 Oct 2023 15:53:19 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: xuanzhenggang001@...suo.com
Cc: ysato@...rs.sourceforge.jp, dalias@...c.org,
glaubitz@...sik.fu-berlin.de, linux-sh@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'
On Sun, Jul 9, 2023 at 2:39 PM <xuanzhenggang001@...suo.com> wrote:
> Fix the following warnings reported by checkpatch:
>
> arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <xuanzhenggang001@...suo.com>
> ---
> arch/sh/drivers/heartbeat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c
> index 24391b444b28..07f04ed0d517 100644
> --- a/arch/sh/drivers/heartbeat.c
> +++ b/arch/sh/drivers/heartbeat.c
> @@ -30,7 +30,7 @@
> static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };
>
> static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
> - unsigned bit, unsigned int inverted)
> + unsigned int bit, unsigned int inverted)
> {
> unsigned int new;
>
> @@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct
> heartbeat_data *hd,
patch: **** malformed patch at line 19: heartbeat_data *hd,
Please fix your email setup.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Powered by blists - more mailing lists