[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <decd9e6f68cbebda22d6648fa7b9b737@208suo.com>
Date: Mon, 10 Jul 2023 12:07:14 +0800
From: sunran001@...suo.com
To: airlied@...il.com, daniel@...ll.ch
Cc: dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] drm/nouveau/nvkm: do not use assignment in if condition
Assignments in if condition are less readable and error-prone. Fixes
also checkpatch warning:
ERROR: do not use assignment in if condition
Signed-off-by:Ran Sun <sunran001@...suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
index 976539de4220..054fa42f1d04 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
@@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func,
struct nvkm_device *device,
if (ccbE.share != DCB_I2C_UNUSED) {
const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
- if (!(pad = nvkm_i2c_pad_find(i2c, id)))
+ pad = nvkm_i2c_pad_find(i2c, id);
+ if (!pad)
ret = func->pad_s_new(i2c, id, &pad);
else
ret = 0;
Powered by blists - more mailing lists