linux-kernel - Re: [PATCH] drm/nouveau/nvkm: do not use assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Jul 2023 11:11:05 +0200
From:   Karol Herbst <kherbst@...hat.com>
To:     sunran001@...suo.com
Cc:     airlied@...il.com, daniel@...ll.ch, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/nouveau/nvkm: do not use assignment in if condition

On Mon, Jul 10, 2023 at 9:23 AM <sunran001@...suo.com> wrote:
>
> Assignments in if condition are less readable and error-prone.  Fixes
> also checkpatch warning:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by:Ran Sun <sunran001@...suo.com>
> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> index 976539de4220..054fa42f1d04 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> @@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func,
> struct nvkm_device *device,
>
>           if (ccbE.share != DCB_I2C_UNUSED) {
>               const int id = NVKM_I2C_PAD_HYBRID(ccbE.share);
> -            if (!(pad = nvkm_i2c_pad_find(i2c, id)))
> +            pad = nvkm_i2c_pad_find(i2c, id);
> +            if (!pad)
>                   ret = func->pad_s_new(i2c, id, &pad);
>               else
>                   ret = 0;
>

Reviewed-by: Karol Herbst <kherbst@...hat.com>