linux-kernel - Re: [PATCH] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d117e562-424f-d128-fa81-41ec9022409f@ixit.cz>
Date:   Mon, 10 Jul 2023 17:36:22 +0200
From:   David Heidelberg <david@...t.cz>
To:     Mark Kettenis <mark.kettenis@...all.nl>,
        Heiko Stuebner <heiko@...ech.de>
Cc:     d3adme4t@...il.com, macromorgan@...mail.com, jbx6244@...il.com,
        f.kardame@...jaro.org, amadeus@....edu.cn, robh+dt@...nel.org,
        linux.amoon@...il.com, aurelien@...el32.net, anarsoul@...il.com,
        wiagn233@...look.com, frattaroli.nicolas@...il.com,
        strit@...jaro.org, luiz.von.dentz@...el.com, zonyitoo@...il.com,
        wens@...e.org, jensenhuang@...endlyarm.com, lasstp5011@...il.com,
        frank-w@...lic-files.de, pgwipeout@...il.com, conor+dt@...nel.org,
        leo@...am.net, andyshrk@....com, krzysztof.kozlowski+dt@...aro.org,
        michael.riesch@...fvision.net, jonas@...boo.se, festevam@...x.de,
        tobetter@...il.com, jagan@...rulasolutions.com, cnsztl@...il.com,
        cristian.ciocaltea@...labora.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, kernel@...labora.com
Subject: Re: [PATCH] arm64: dts: rockchip: Drop invalid
 regulator-init-microvolt property

On 10/07/2023 16:35, Mark Kettenis wrote:
>> From: Heiko Stuebner <heiko@...ech.de>
>> Date: Mon, 10 Jul 2023 16:16:16 +0200
>>
>> On Fri, 7 Jul 2023 19:22:17 +0300, Cristian Ciocaltea wrote:
>>> The 'regulator-init-microvolt' property is not currently supported by
>>> any driver, it was simply carried on from downstream kernels.
>>>
>>> The problem is also indicated by the following dtbs_check warning:
>>>
>>>    rk3588-rock-5b.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
>>>
>>> [...]
>> Applied, thanks!
>>
>> [1/1] arm64: dts: rockchip: Drop invalid regulator-init-microvolt property
>>        commit: 4d08b19629495b29601991d09d07865694c25199
> This property *is used* by the drivers in U-Boot.  Dropping this from
> the Linux DTBs will likely result in broken boards the next time the
> U-Boot DTBs are synched again from Linux.  At least that is what
> happened before...
Well, if u-boot uses these properties, u-boot folks should document them 
in bindings ;-)
I found some u-boot mentions reviewing this patch, but only the DTS 
files copied from Linux poped-up.
>
> I think the right solution is to add this property to the DT binding
> instead.

Sure, it should be sent together with the revert.
DT binding property description could also note that the bootloader(s) 
use the value.

David

-- 
David Heidelberg
Consultant Software Engineer