linux-kernel - Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2023 13:34:48 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     sunran001@...suo.com
Cc:     airlied@...il.com, daniel@...ll.ch, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"

Applied.  Thanks.  I've applied all the patches you sent out, but all
of them had whitespace problems.  Please double check your mailer on
any future submissions.

Thanks,

Alex

On Mon, Jul 10, 2023 at 6:03 AM <sunran001@...suo.com> wrote:
>
> Fix five occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>   drivers/gpu/drm/radeon/radeon_kms.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_kms.c
> b/drivers/gpu/drm/radeon/radeon_kms.c
> index e0214cf1b43b..a16590c6247f 100644
> --- a/drivers/gpu/drm/radeon/radeon_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_kms.c
> @@ -444,7 +444,7 @@ int radeon_info_ioctl(struct drm_device *dev, void
> *data, struct drm_file *filp)
>               DRM_DEBUG_KMS("timestamp is r6xx+ only!\n");
>               return -EINVAL;
>           }
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           value64 = radeon_get_gpu_clock_counter(rdev);
>           break;
> @@ -543,18 +543,18 @@ int radeon_info_ioctl(struct drm_device *dev, void
> *data, struct drm_file *filp)
>           *value = rdev->vce.fb_version;
>           break;
>       case RADEON_INFO_NUM_BYTES_MOVED:
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           value64 = atomic64_read(&rdev->num_bytes_moved);
>           break;
>       case RADEON_INFO_VRAM_USAGE:
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           man = ttm_manager_type(&rdev->mman.bdev, TTM_PL_VRAM);
>           value64 = ttm_resource_manager_usage(man);
>           break;
>       case RADEON_INFO_GTT_USAGE:
> -        value = (uint32_t*)&value64;
> +        value = (uint32_t *)&value64;
>           value_size = sizeof(uint64_t);
>           man = ttm_manager_type(&rdev->mman.bdev, TTM_PL_TT);
>           value64 = ttm_resource_manager_usage(man);
> @@ -614,7 +614,7 @@ int radeon_info_ioctl(struct drm_device *dev, void
> *data, struct drm_file *filp)
>           DRM_DEBUG_KMS("Invalid request %d\n", info->request);
>           return -EINVAL;
>       }
> -    if (copy_to_user(value_ptr, (char*)value, value_size)) {
> +    if (copy_to_user(value_ptr, (char *)value, value_size)) {
>           DRM_ERROR("copy_to_user %s:%u\n", __func__, __LINE__);
>           return -EFAULT;
>       }