[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2023071056-amused-yam-5e29@gregkh>
Date: Mon, 10 Jul 2023 07:47:04 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Zhang Shurong <zhang_shurong@...mail.com>
Cc: Markus Elfring <Markus.Elfring@....de>,
linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
LKML <linux-kernel@...r.kernel.org>,
Dan Carpenter <error27@...il.com>,
Xu Panda <xu.panda@....com.cn>
Subject: Re: staging: ks7010: potential buffer overflow in
ks_wlan_set_encode_ext()
On Mon, Jul 10, 2023 at 01:41:07PM +0800, Zhang Shurong wrote:
> Hi Markus,
>
> > 2023年7月10日 03:56,Markus Elfring <Markus.Elfring@....de> 写道:
> >
> >>>> The "exc->key_len" is a u16 that comes from the user. If it's over
> >>>> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
> >>>
> >>> Please choose an imperative change suggestion.
> >>
> >> Please stop reviewing staging patches, it is not helpful for anyone.
> >
> > It seems that further contributors need to become more aware about
> > (and finally adhere to) requirements from the Linux development documentation.
> >
> > Regards,
> > Markus
>
> I'm guilty of my incorrect patch format. And do I need to write another
> patch to fix this format issue?
One of the hardest things in kernel development is learning what
reviews, and what reviewers, should be ignored. This is one of them :)
No need to change the patch yet, let me get to this change this week and
I'll let you know.
thanks,
greg k-h
Powered by blists - more mailing lists