linux-kernel - Re: staging: ks7010: potential buffer overflow in ks_wlan_set_encode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_BB4124566E846A2FB6ECC0F63C5A15BE5009@qq.com>
Date:   Mon, 10 Jul 2023 13:41:07 +0800
From:   Zhang Shurong <zhang_shurong@...mail.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Dan Carpenter <error27@...il.com>,
        Xu Panda <xu.panda@....com.cn>
Subject: Re: staging: ks7010: potential buffer overflow in
 ks_wlan_set_encode_ext()

Hi Markus,

> 2023年7月10日 03:56，Markus Elfring <Markus.Elfring@....de> 写道：
> 
>>>> The "exc->key_len" is a u16 that comes from the user.  If it's over
>>>> IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
>>> 
>>> Please choose an imperative change suggestion.
>> 
>> Please stop reviewing staging patches, it is not helpful for anyone.
> 
> It seems that further contributors need to become more aware about
> (and finally adhere to) requirements from the Linux development documentation.
> 
> Regards,
> Markus

I'm guilty of my incorrect patch format. And do I need to write another
patch to fix this format issue?

Best regards
Shurong