linux-kernel - Re: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d69221f2-4947-f4e5-4a37-550ba13a0d9f@linaro.org>
Date:   Mon, 10 Jul 2023 08:23:47 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Pankaj Gupta <pankaj.gupta@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Varun Sethi <V.Sethi@....com>
Subject: Re: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr

On 10/07/2023 07:27, Pankaj Gupta wrote:
> Hi All,
> 
> Gentle reminder. Please review this patch.
> 
> Thanks.
> Pankaj
> 
>> -----Original Message-----
>> From: Pankaj Gupta <pankaj.gupta@....com>
>> Sent: Monday, June 26, 2023 10:17 AM
>> To: robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
>> conor+dt@...nel.org; shawnguo@...nel.org; s.hauer@...gutronix.de;
>> kernel@...gutronix.de; festevam@...il.com; dl-linux-imx <linux-
>> imx@....com>; devicetree@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
>> Cc: Pankaj Gupta <pankaj.gupta@....com>; Varun Sethi <V.Sethi@....com>
>> Subject: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr
>>
>> V2: Changed the email subject line.
>> ------------------------------------------------
>>
>>

That's not a place for changelog. It goes after --- .

>> Add crypto node in device tree for:
>> - CAAM job-ring
>>
>> Signed-off-by: Varun Sethi <v.sethi@....com>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@....com>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 32
>> ++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> index 32193a43ff49..ce8de81cac9a 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> @@ -207,6 +207,38 @@ pcc3: clock-controller@...d0000 {
>>  				#reset-cells = <1>;
>>  			};
>>
>> +			crypto: crypto@...e0000 {
>> +				compatible = "fsl,sec-v4.0";
>> +				#address-cells = <1>;
>> +				#size-cells = <1>;
>> +				reg = <0x292e0000 0x10000>;

reg is after compatible

>> +				ranges = <0 0x292e0000 0x10000>;

ranges should be third.

>> +


Best regards,
Krzysztof