linux-kernel - Re: [PATCH v2] drm/mediatek: Fix void-pointer-to-enum-cast warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b7769eb121b2241881f2eb3f5756ce8ceb95f862.camel@mediatek.com>
Date:   Mon, 10 Jul 2023 02:13:38 +0000
From:   CK Hu (胡俊光) <ck.hu@...iatek.com>
To:     Jason-JH Lin (林睿祥) 
        <Jason-JH.Lin@...iatek.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Singo Chang (張興國) 
        <Singo.Chang@...iatek.com>,
        Johnson Wang (王聖鑫) 
        <Johnson.Wang@...iatek.com>,
        Jason-ch Chen (陳建豪) 
        <Jason-ch.Chen@...iatek.com>,
        Shawn Sung (宋孝謙) 
        <Shawn.Sung@...iatek.com>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Nancy Lin (林欣螢) <Nancy.Lin@...iatek.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2] drm/mediatek: Fix void-pointer-to-enum-cast warning

Hi, Jason:

On Wed, 2023-06-21 at 15:54 +0800, Jason-JH.Lin wrote:
> 1. Fix build warning message in mtk_disp_ovl_adaptor.c
> > > drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c:415:10:
> 
>   warning: cast to smaller integer type 'enum
> mtk_ovl_adaptor_comp_type'
>   from 'const void *' [-Wvoid-pointer-to-enum-cast]
> 
>   type = (enum mtk_ovl_adaptor_comp_type)of_id->data;
> 
>          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>          1 warning generated.
> 
> 2. Also fix the same warning message in mtk_drm_drv.c
> > > drivers/gpu/drm/mediatek/mtk_drm_drv.c:832:15:
> 
>    warning: cast to smaller integer type 'enum mtk_ddp_comp_type'
>    from 'const void *' [-Wvoid-pointer-to-enum-cast]
> 
>    comp_type = (enum mtk_ddp_comp_type)of_id->data;
> 
>                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                1 warning generated.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> Fixes: 453c3364632a ("drm/mediatek: Add ovl_adaptor support for
> MT8195")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202305042054.ZtWME9OU-lkp@intel.com/
> ---
> V1 -> V2: Add casting to (uintprt_t) before casting from (void *) to
> (enum).
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 2 +-
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c          | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> index c0a38f5217ee..f2f6a5c01a6d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> @@ -426,7 +426,7 @@ static int ovl_adaptor_comp_init(struct device
> *dev, struct component_match **ma
>  			continue;
>  		}
>  
> -		type = (enum mtk_ovl_adaptor_comp_type)of_id->data;
> +		type = (enum
> mtk_ovl_adaptor_comp_type)(uintptr_t)of_id->data;
>  		id = ovl_adaptor_comp_get_id(dev, node, type);
>  		if (id < 0) {
>  			dev_warn(dev, "Skipping unknown component
> %pOF\n",
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index 6dcb4ba2466c..80d3bcd315a9 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -829,7 +829,7 @@ static int mtk_drm_probe(struct platform_device
> *pdev)
>  			continue;
>  		}
>  
> -		comp_type = (enum mtk_ddp_comp_type)of_id->data;
> +		comp_type = (enum mtk_ddp_comp_type)(uintptr_t)of_id-
> >data;
>  
>  		if (comp_type == MTK_DISP_MUTEX) {
>  			int id;